Skip to content

Fix a RemoveProcessor test that never ran #126464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 8, 2025
Merged

Fix a RemoveProcessor test that never ran #126464

merged 3 commits into from
Apr 8, 2025

Conversation

@joegallo
Copy link
Contributor

@joegallo joegallo commented Apr 8, 2025

The important bit is the change to the signature of testShouldKeep which makes the test actually run. 😬

@joegallo joegallo added >test Issues or PRs that are addressing/adding tests :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP Team:Data Management Meta label for data/management team auto-backport Automatically create backport pull requests when merged v8.19.0 v9.0.1 v9.1.0 labels Apr 8, 2025
@joegallo joegallo requested a review from parkertimmins April 8, 2025 13:55
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Apr 8, 2025

Pinging @elastic/es-data-management (Team:Data Management)

@joegallo joegallo merged commit 450516d into elastic:main Apr 8, 2025
17 checks passed
@joegallo joegallo deleted the fix-remove-processor-test branch April 8, 2025 15:21
@joegallo joegallo mentioned this pull request Apr 8, 2025
Merged
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Apr 8, 2025

💔 Backport failed

Status Branch Result
✅ 8.x
❌ 9.0 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 126464

@joegallo joegallo mentioned this pull request Apr 8, 2025
Merged
elasticsearchmachine pushed a commit that referenced this pull request Apr 8, 2025
@joegallo
Fix a RemoveProcessor test that never ran (#126464) (#126477)
1e6cdc3
elasticsearchmachine pushed a commit that referenced this pull request Apr 8, 2025
@joegallo
[9.0] Fix a RemoveProcessor test that never ran (#126464) (#126481)
6ffa705 
* Conserve precious characters

* Whitespace

* Make this test actually run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parkertimmins parkertimmins parkertimmins approved these changes

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP Team:Data Management Meta label for data/management team >test Issues or PRs that are addressing/adding tests v8.19.0 v9.0.1 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joegallo @elasticsearchmachine @parkertimmins